feat: improve packet handling #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes several changes: - Packets now have metadata. This metadata can be used to prevent a specific player from receiving a packet and to mark the packet as being allowed to be dropped. - Packets can be dropped. This is useful to stop clients from going more and more into the past. For example, if a client has a 1 MiB/s download speed and the server is sending the client 2 MiB/s of entity movement packets, the client will be more behind as time progresses. To solve this, some movement packets will be dropped. - Includes functions to get players' download speed, ping, and send window size which will be useful to determine how much data needs to be dropped. - Removes the `server_port == 25565` check so it's easier to use a proxy to connect to the server.
|
Ideally the randomness is replaced with the broadcast code from #17 |
|
Thanks for your work. I will review it tomorrow when I wake up. :) |
andrewgazelka
requested changes
Apr 1, 2024
andrewgazelka
changed the title
andrewgazelka
approved these changes
Apr 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several changes:
server_port == 25565check so it's easier to use a proxy to connect to the server.